Skip to content

check gui does not immediately terminate take 2 #18292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

check gui does not immediately terminate take 2 #18292

wants to merge 9 commits into from

Conversation

altendky
Copy link
Contributor

  • test that installers do not exit immediately
  • only for gui mode testing
  • print something

Purpose:

Current Behavior:

New Behavior:

Testing Notes:

@altendky altendky added Added Required label for PR that categorizes merge commit message as "Added" for changelog CI CI changes labels Jul 10, 2024
@altendky altendky mentioned this pull request Jul 10, 2024
Closed
@github-actions github-actions bot added the merge_conflict Branch has conflicts that prevent merge to main label Jul 15, 2024
@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions GitHub Actions
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@github-actions github-actions bot added coverage-diff and removed merge_conflict Branch has conflicts that prevent merge to main labels Aug 19, 2024
@coveralls-official Coveralls Official
Copy link

Pull Request Test Coverage Report for Build 10456098776

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 4 of 13 (30.77%) changed or added relevant lines in 1 file are covered.
  • 14 unchanged lines in 7 files lost coverage.
  • Overall coverage increased (+0.02%) to 90.873%
Changes Missing Coverage Covered Lines Changed/Added Lines %
chia/cmds/installers.py 4 13 30.77%
Files with Coverage Reduction New Missed Lines %
chia/timelord/timelord.py 1 81.88%
chia/rpc/rpc_server.py 1 88.82%
chia/server/node_discovery.py 1 81.03%
chia/daemon/client.py 1 73.94%
chia/full_node/weight_proof.py 2 90.51%
chia/full_node/full_node.py 2 86.26%
chia/full_node/full_node_api.py 6 82.57%
Totals Coverage Status
Change from base Build 10423078207: 0.02%
Covered Lines: 101351
Relevant Lines: 111512
💛 - Coveralls

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 4, 2024

This PR has been flagged as stale due to no activity for over 60 days. It will not be automatically closed, but it has been given a stale-pr label and should be manually reviewed by the relevant parties.

@github-actions github-actions bot added the stale-pr Flagged as stale and in need of manual review label Oct 4, 2024
@github-actions github-actions bot added the merge_conflict Branch has conflicts that prevent merge to main label Oct 16, 2024
@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the stale-pr Flagged as stale and in need of manual review label Oct 17, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 2, 2024

This PR has been flagged as stale due to no activity for over 60 days. It will not be automatically closed, but it has been given a stale-pr label and should be manually reviewed by the relevant parties.

@github-actions github-actions bot added the stale-pr Flagged as stale and in need of manual review label Dec 2, 2024
@github-actions github-actions bot removed the merge_conflict Branch has conflicts that prevent merge to main label Aug 20, 2025
@github-actions GitHub Actions
Copy link
Contributor

File Coverage Missing Lines
chia/cmds/dev/installers.py 30.8% lines 136-137, 139-142, 147-148, 150
Total Missing Coverage
13 lines 9 lines 30%

@github-actions github-actions bot removed the stale-pr Flagged as stale and in need of manual review label Aug 21, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 6, 2025

This PR has been flagged as stale due to no activity for over 60 days. It will not be automatically closed, but it has been given a stale-pr label and should be manually reviewed by the relevant parties.

@github-actions github-actions bot added the stale-pr Flagged as stale and in need of manual review label Oct 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Added Required label for PR that categorizes merge commit message as "Added" for changelog CI CI changes coverage-diff stale-pr Flagged as stale and in need of manual review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@altendky